Skip to content

Prevent the execution of refreshDraftOrderAdjustmentsWorkflow when not a draft order#14753

Open
pepijn-vanvlaanderen wants to merge 2 commits intomedusajs:developfrom
webbersagency:fix/prevent-refresh-draft-order-adjustments-when-not-draft-order
Open

Prevent the execution of refreshDraftOrderAdjustmentsWorkflow when not a draft order#14753
pepijn-vanvlaanderen wants to merge 2 commits intomedusajs:developfrom
webbersagency:fix/prevent-refresh-draft-order-adjustments-when-not-draft-order

Conversation

@pepijn-vanvlaanderen
Copy link
Contributor

@pepijn-vanvlaanderen pepijn-vanvlaanderen commented Feb 12, 2026

Summary

What — What changes are introduced in this PR?

Only trigger the refreshDraftOrderAdjustmentsWorkflow in the create order workflow when it is actually a draft order.

Why — Why are these changes relevant or necessary?

When using the create order workflow (we use it when creating subscription renewal orders) with custom line item adjustments, the refreshDraftOrderAdjustmentsWorkflow workflow will remove them.

How — How have these changes been implemented?

Wrapped the refreshDraftOrderAdjustmentsWorkflow in a when check.

Testing — How have these changes been tested, or how can the reviewer test the feature?

Patchted it for our project(s). Validated this is still triggered when doing draft order changes.

Checklist

Please ensure the following before requesting a review:

  • I have added a changeset for this PR
    • Every non-breaking change should be marked as a patch
    • To add a changeset, run yarn changeset and follow the prompts
  • The changes are covered by relevant tests
  • I have verified the code works as intended locally
  • I have linked the related issue(s) if applicable

@pepijn-vanvlaanderen pepijn-vanvlaanderen requested a review from a team as a code owner February 12, 2026 12:38
@changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: c0c7817

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 76 packages
Name Type
@medusajs/core-flows Patch
@medusajs/medusa Patch
@medusajs/test-utils Patch
integration-tests-http Patch
@medusajs/medusa-oas-cli Patch
@medusajs/analytics Patch
@medusajs/api-key Patch
@medusajs/auth Patch
@medusajs/caching Patch
@medusajs/cart Patch
@medusajs/currency Patch
@medusajs/customer Patch
@medusajs/file Patch
@medusajs/fulfillment Patch
@medusajs/index Patch
@medusajs/inventory Patch
@medusajs/link-modules Patch
@medusajs/locking Patch
@medusajs/notification Patch
@medusajs/order Patch
@medusajs/payment Patch
@medusajs/pricing Patch
@medusajs/product Patch
@medusajs/promotion Patch
@medusajs/rbac Patch
@medusajs/region Patch
@medusajs/sales-channel Patch
@medusajs/settings Patch
@medusajs/stock-location Patch
@medusajs/store Patch
@medusajs/tax Patch
@medusajs/translation Patch
@medusajs/user Patch
@medusajs/workflow-engine-inmemory Patch
@medusajs/workflow-engine-redis Patch
@medusajs/draft-order Patch
@medusajs/oas-github-ci Patch
@medusajs/cache-inmemory Patch
@medusajs/cache-redis Patch
@medusajs/event-bus-local Patch
@medusajs/event-bus-redis Patch
@medusajs/analytics-local Patch
@medusajs/analytics-posthog Patch
@medusajs/auth-emailpass Patch
@medusajs/auth-github Patch
@medusajs/auth-google Patch
@medusajs/caching-redis Patch
@medusajs/file-local Patch
@medusajs/file-s3 Patch
@medusajs/fulfillment-manual Patch
@medusajs/locking-postgres Patch
@medusajs/locking-redis Patch
@medusajs/notification-local Patch
@medusajs/notification-sendgrid Patch
@medusajs/payment-stripe Patch
@medusajs/framework Patch
@medusajs/js-sdk Patch
@medusajs/modules-sdk Patch
@medusajs/orchestration Patch
@medusajs/types Patch
@medusajs/utils Patch
@medusajs/workflows-sdk Patch
@medusajs/cli Patch
@medusajs/deps Patch
@medusajs/telemetry Patch
@medusajs/admin-bundler Patch
@medusajs/admin-sdk Patch
@medusajs/admin-shared Patch
@medusajs/admin-vite-plugin Patch
@medusajs/dashboard Patch
@medusajs/icons Patch
@medusajs/toolbox Patch
@medusajs/ui-preset Patch
create-medusa-app Patch
medusa-dev-cli Patch
@medusajs/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 12, 2026

@pepijn-vanvlaanderen is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@pepijn-vanvlaanderen pepijn-vanvlaanderen mentioned this pull request Feb 12, 2026
Open
@NicolasGorga
Copy link
Contributor

NicolasGorga commented Feb 12, 2026

Hey @pepijn-vanvlaanderen I want to understand a little bit more the issue you are describing of line item adjustments being removed. The workflow removes but re-adds adjustments, provided that they are still valid for the order. Can you expand a little bit more about what these adjustments are, since I don't believe it is tied to the order being or not a draft order.

@pepijn-vanvlaanderen
Copy link
Contributor Author

pepijn-vanvlaanderen commented Feb 12, 2026

Hi @NicolasGorga, thanks for your reply. The line items that are passed are custom adjustments for our subscription items, not tied to a specific promotion. In this case these are thus not re-added again.

@NicolasGorga
Copy link
Contributor

NicolasGorga commented Feb 13, 2026

@pepijn-vanvlaanderen can you expand on these custom line items? We are talking about line item adjustments not line items right? Could you maybe share the JSON of how the order looks like before the refreshDraftOrderAdjustmentsWorkflow runs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pepijn-vanvlaanderen @NicolasGorga